[Bug 227190] Review Request: php-pear-Auth-OpenID - PHP OpenID

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Auth-OpenID - PHP OpenID


https://bugzilla.redhat.com/show_bug.cgi?id=227190





------- Additional Comments From lemenkov at gmail.com  2008-07-31 09:45 EST -------
REVIEW:

MUST Items:

+ rpmlint is silent
+ The package named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the Licensing
Guidelines.
+ The License field in the package spec file matches the actual license.
+ The text of the license(s) included in %doc.
+ The spec file written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package match the upstream source.

[petro at Sulaco SOURCES]$ md5sum php-openid-2.1.1.tar.bz2*
2fd3e4284f106f8a77fd5ba9c83b30f9  php-openid-2.1.1.tar.bz2
2fd3e4284f106f8a77fd5ba9c83b30f9  php-openid-2.1.1.tar.bz2.1
[petro at Sulaco SOURCES]$

+ The package successfully compiles and builds into binary rpms on at least one
supported architecture (tested on ppc).
+ All build dependencies are listed in BuildRequires.
+ A package owns all directories that it creates.
+ A package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ Each package has a %clean section.
+ Each package consistently uses macros.
+ The package contains code, or permissable content.
+ Packages does not own files or directories already owned by other packages. 
+ At the beginning of %install, each package runs rm -rf %{buildroot} 
+ All filenames in rpm packages are valid UTF-8.

However I still have some suggestions.

* docs should be packaged more consistently:

http://peter.fedorapeople.org/php-pear-Auth-OpenID_docs.diff

There are some valuable suggestions taken from Ian's spec:

http://peter.fedorapeople.org/php-openid.spec

* The package should provide php-yadis (seems that it should "Provides:
php-pear(Auth_Yadis) = 1.0.2" or something similar)
* Should it require php-pear-DB instead of php-pgsql and php-mysql (and
commented out php-sqlite)? I'm not sure, though.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.