[Bug 441415] Review Request: wastesedge - Official game package for Adonthell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wastesedge - Official game package for Adonthell


https://bugzilla.redhat.com/show_bug.cgi?id=441415





------- Additional Comments From j.w.r.degoede at hhs.nl  2008-06-01 04:47 EST -------
Full review done, results:

Must Fix
--------

* The GPL version to use does not get specified anywhere, so the correct License
  tag is GPL+ not GPLv2+

* Drop the obsolete Encoding and Version entries from the .desktop file



Should Fix
----------

* Drop the #%files line (why is that there anyways?)

* Add INSTALL="install -p" as argument to make install to preserve the 
  timestamps of the files getting installed

* Install icons in freedesktop.org icon standard location (/usr/share/pixmaps
  is deprecated) :
  mv wastesedge_16x16.xpm /usr/share/icons/hicolor/16x16/apps/wastesedge.xpm
  mv wastesedge_32x32.xpm /usr/share/icons/hicolor/32x32/apps/wastesedge.xpm
  Add a "Requires: hicolor-icon-theme" for icon dirs ownership
  Add ican-cache update scriptlets from:
   http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache
  Change Icon line in .desktop to just "Icon=wastesedge"


One all that is done its time for the next step as described in my initial comment:

"The next step then is for you to either package one or two more
packages, for example from these lists:
http://fedoraproject.org/wiki/SIGs/Games/WishList
http://fedoraproject.org/wiki/PackageMaintainers/WishList

Or you can do some reviews of other people packages, when you do this please add
a note that it is not an official review as you aren't a contributer yet.

The purpose here is for you to show a good understanding of the packaging
guidelines. Once you've done a couple of good reviews and / or submitted one or
two more good packages, then you can apply for cvsextras membership in the
account system and I'll sponsor you."

So I would like you to either create one more package, or do 2 good reviews of
other peoples submissions.




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.