[Bug 411551] Review Request: perl-DBIx-Class - Extensible and flexible object <-> relational mapper

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DBIx-Class - Extensible and flexible object <-> relational mapper
Alias: perl-DBIx-Class

https://bugzilla.redhat.com/show_bug.cgi?id=411551


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-06-02 00:54 EST -------
Review:
+ package builds in mock.
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=640082
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5b7eee3c1ddf6f865c816cde9e9bdf62  DBIx-Class-0.08010.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful (7 subtests UNEXPECTEDLY SUCCEEDED), 15 tests and 18
subtests skipped.
Passed TODO        Stat Wstat TODOs Pass  List of Passed
-------------------------------------------------------------------------------
t/81transactions.t               13    7  55 59 61-65
Files=106, Tests=2568, 48 wallclock secs (39.58 cusr +  4.35 csys = 43.93 CPU)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.