[Bug 445140] Review Request: lxtask - Lightweight and desktop independent task manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lxtask - Lightweight and desktop independent task manager


https://bugzilla.redhat.com/show_bug.cgi?id=445140


michel.sylvan at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From michel.sylvan at gmail.com  2008-06-03 23:47 EST -------
Looks fine -- approved. Note that you can drop the version number from the BR on
gtk2-devel; no currently-supported release of Fedora or RHEL has an older GTK+
than the version required.

APPROVED

MUST

• rpmlint: clean
• package name: ok
• spec file name: ok
• package guideline-compliant: ok
• license complies with guidelines: ok
• license field accurate: ok
• license file not deleted: ok
• spec in US English: ok
• spec legible: ok
• source matches upstream: ok
• builds under >= 1 archs, others excluded: ok
• build dependencies complete: 
• locales handled using %find_lang, no %{_datadir}/locale: ok
• own all directories: ok
• no dupes in %files: ok
• permission: ok
• %clean RPM_BUILD_ROOT: ok
• macros used consistently: ok
• Package contains code: ok
• desktop file uses desktop-file-install: ok
• clean buildroot before install: ok
• filenames UTF-8: ok

SHOULD
• desc and summary contain translations if available: no (optional)
• package build in mock on all architectures: ok
  http://koji.fedoraproject.org/koji/taskinfo?taskID=644423
• package functioned as described: ok
• scriplets are sane: ok
• require package not files: ok

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.