[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO


https://bugzilla.redhat.com/show_bug.cgi?id=432259





------- Additional Comments From goyal.hemant at gmail.com  2008-06-04 11:57 EST -------
Hi :-)

SPEC File for revision 7 -
http://www.nsitonline.in/hemant/stuff/speechd-rpm/speech-dispatcher.spec

SRPM -
http://www.nsitonline.in/hemant/stuff/speechd-rpm/speech-dispatcher-0.6.6-7.fc7.src.rpm

(In reply to comment #24)
> For 0.6.6-6:
> 
> * License
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
>   - I checked the license of speech-dispatcher and
>     * The base license of this is GPLv2+
>     * src/c/clients/spdsend/spdsend.h in the tarball is under
>       GPL, which makes %_bindir/spdsend to be GPLv2:
> 
>     So
>     * Please change the license tag of all packages except 
>       speech-dispatcher (main) pkg to "GPLv2+"
>     * For speech-dispatcher, write in the spec file like below:
> -----------------------------------------------------------
> Group:          System Environment/Libraries
> # Almost all files are under GPLv2+, however 
> # src/c/clients/spdsend/spdsend.h is licensed under GPLv2,
> # which makes %%_bindir/spdsend GPLv2.
> License:        GPLv2+ and GPLv2
> URL:            http://www.freebsoft.org/pub/projects/speechd/
> -----------------------------------------------------------

Done.

> 
> * Requires(%post,etc)
>   - Why are /sbin/chkconfig, /sbin/service needed for
>     Requires(%post,etc)?

I wanted to add an init script to auto-start the speech-dispatcher daemon. Hence
the need for chkconfig. I've included the init script as a patch in the latest
revision.
> 
> * %install process
>   - Would you clean up %install scripts (like following)?
> -----------------------------------------------------------
> for dir in \
> 	config doc src/audio c ..... 
> 	do
> 	pushd $dir
> 	make install DESTDIR=$RPM_BUILD_ROOT
> 	popd
> done
> -----------------------------------------------------------

Neat :). Done


> * Documents
>   - Adding "COPYING" to %doc is rather mandatory if it exists.
Done


> * rpmlint issue
> -----------------------------------------------------------
> speech-dispatcher-doc.i386: W: file-not-utf8
> /usr/share/info/speech-dispatcher-cs.info.gz

Still to be resolved. Wondering how to go about this one (:-?)

> speech-dispatcher-devel.i386: W: no-documentation
> speech-dispatcher-python.i386: W: no-documentation

Is this warning very important, as most of the documentation has been included
in a separate doc pacakge?

> speech-dispatcher.i386: E: non-empty-%postun /sbin/ldconfig

Fixed.

> speech-dispatcher-python.i386: E: non-executable-script
> /usr/lib/python2.5/site-packages/speechd/_test.py 0644
> speech-dispatcher.i386: E: postun-without-ldconfig /usr/lib/libspeechd.so.2.0.5

Fixed
 
> * Binary name
>   - IMO the names of the binaries
> -----------------------------------------------------------
> %_bindir/long_message
> %_bindir/run_test
> -----------------------------------------------------------

prefixed spd_ to each file. I hope that is fine? Any other suggestion that you
have for the file name?

Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.