[Bug 448566] Review Request: xorg-x11-drv-sunleo - X driver for sunleo hardware
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 5 01:06:41 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xorg-x11-drv-sunleo - X driver for sunleo hardware
https://bugzilla.redhat.com/show_bug.cgi?id=448566
bdpepple at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review+
------- Additional Comments From bdpepple at gmail.com 2008-06-04 21:06 EST -------
Good:
* Verified source tarball against git.
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds.
* Files have appropriate permissions and owners
Bad:
* rpmlint produces the following error:
xorg-x11-drv-sunleo.sparc64: W: invalid-license MIT/X11
Looking at the license matrix, it looks like it should just be MIT. You can fix
this when you import this into CVS.
Note: I don't have the hardware to verify that this driver works, but from a
packaging standpoint this package looks fine.
+1 APPROVE.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list