[Bug 449328] Review Request: cluttermm - C++ wrapper for clutter library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cluttermm - C++ wrapper for clutter library


https://bugzilla.redhat.com/show_bug.cgi?id=449328


bdpepple at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |bdpepple at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From bdpepple at gmail.com  2008-06-04 21:43 EST -------
MD5Sum:
74ea582eccf312885bd190758018b5a2  cluttermm-0.5.1.tar.bz2

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Valid license tag
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Rpmlint produces the following warnings that can be ignored:
  cluttermm-cairo.i386: W: no-documentation
  cluttermm-gtk.i386: W: no-documentation
* Package installs and uninstalls cleanly

Bad:
* Looking at the pkg-config files for some of your devel subpackages, it looks
like your missing a couple of requires.  The cluttermm-cairo-devel package looks
like it's missing a requires on cairomm-devel. The cluttermm-gtk-devel package
looks like it's missing a requires on gtkmm24-devel.  Please verify this before
importing it into CVS.

+1 APPROVE


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.