[Bug 448236] Review Request: xfbib - Lightweight BibTeX editor for the Xfce desktop environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfbib - Lightweight BibTeX editor for the Xfce desktop environment


https://bugzilla.redhat.com/show_bug.cgi?id=448236





------- Additional Comments From michel.sylvan at gmail.com  2008-06-05 01:12 EST -------
In case where the vendor is not already set, then yes, adding "fedora" is
probably the thing to do (or add "xfce" instead? I'll leave it to your
discretion). And yes, the "Extras" thing can be done without.

As it turns out, there are a couple of other problems, all easily fixable. Need
to ask a small favour -- could you review a couple of my requests in turn? Much
obliged:

https://bugzilla.redhat.com/buglist.cgi?query_format=&short_desc_type=allwordssubstr&short_desc=&product=Fedora&version=&component=Package+Review&query_format=advanced&bug_status=NEW&bug_status=ASSIGNED&bug_status=NEEDINFO&bug_status=MODIFIED&long_desc_type=allwordssubstr&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&fixed_in_type=allwordssubstr&fixed_in=&qa_whiteboard_type=allwordssubstr&qa_whiteboard=&keywords_type=allwords&keywords=&bugidtype=include&bug_id=&emailreporter1=1&emailtype1=exact&email1=michel.sylvan%40gmail.com&emailtype2=exact&email2=&votes=&changedin=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=flagtypes.name&type0-0-0=notsubstring&value0-0-0=fedora-review

MUSTFIX:
• own all directories: FAIL
  installs files in %{_datadir}/icons/hicolor: need to require hicolor-icon-theme

SHOULDFIX:
• scriplets are sane: add vendor (fedora or xfce)

MUST, passed:
• rpmlint: clean
• package name: ok
• spec file name: ok
• package guideline-compliant: ok
• license complies with guidelines: ok
• license field accurate: ok
• license file not deleted: ok
• spec in US English: ok
• spec legible: ok
• source matches upstream: ok
• builds under >= 1 archs, others excluded: ok
• build dependencies complete: ok
• locales handled using %find_lang, no %{_datadir}/locale: ok
• no dupes in %files: ok
• permission: ok
• %clean RPM_BUILD_ROOT: ok
• macros used consistently: ok
• Package contains code: ok
• desktop file uses desktop-file-install: ok
• clean buildroot before install: ok
• filenames UTF-8: ok

SHOULD
• desc and summary contain translations if available: ok
• package build in mock on all architectures: ok
  http://koji.fedoraproject.org/koji/taskinfo?taskID=647081
• package functioned as described: ok
• require package not files: ok



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.