[Bug 449994] Review Request: lua-expat - SAX XML parser based on the Expat library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lua-expat - SAX XML parser based on the Expat library


https://bugzilla.redhat.com/show_bug.cgi?id=449994





------- Additional Comments From tim at niemueller.de  2008-06-05 07:48 EST -------
(In reply to comment #1)
> Looks pretty good; only a few of things worth mentioning.
> 
> There seems to be at least a small test suite in the tests directory; is it
> possible to run it at build time?

Yes, for this one it is possible. Added %check macro.

> There's no need for the explicit build dependency on /usr/bin/iconv; it's part
> of glibc so you can expect it to be there, although it doesn't hurt anything.

I keep this one as it seems to be the right thing to me.

> You should use either $RPM_BUILD_ROOT and $RPM_OPT_FLAGS or %{buildroot} and
> %{optflags}; currently they're mixed.  It's not a really big deal in a package
> this small but it is explicitly prohibited by the guidelines.

Fixed.

New SRPM at http://fedorapeople.org/~timn/luastuff/lua-expat-1.1-2.fc9.src.rpm,
spec file at the original URL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.