[Bug 444735] Review Request: staden-io_lib - General purpose trace file library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: staden-io_lib - General purpose trace file library


https://bugzilla.redhat.com/show_bug.cgi?id=444735





------- Additional Comments From tibbs at math.uh.edu  2008-06-05 23:07 EST -------
I'll assume the changed name throughout.

It's not a big deal, but reading the summary makes me think that this parses
output from strace or something.  Perhaps you could elaborate on "trace file",
maybe adding something like "gene sequencing machine" before it if that's
actually appropriate.

It looks like 1.11.2 is currently available, although it doesn't seem like
anything significant has changed so I see no reason to wait for you to update
the package before I look at it.

I have to say, "libread" is a rather unfortunate name for a library.  Is there
any possibility of renaming it to something more unique?  It should be pretty
easy to do this given the -config binary.

* source files match upstream:
   3fc0f26aff8e95b7f37f55c4bcf6c462f413a0488a4b8ee1c3a81e3db7f591a4  
   io_lib-1.11.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summaries are OK.
* descriptions are OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
  io_lib-1.11.0-0.fc10.x86_64.rpm
   io_lib = 1.11.0-0.fc10
  =
   libcurl.so.4()(64bit)
   libz.so.1()(64bit)

  io_lib-devel-1.11.0-0.fc10.x86_64.rpm
   io_lib-static = 1.11.0-0.fc10
   io_lib-devel = 1.11.0-0.fc10
  =
   /bin/sh
   io_lib = 1.11.0-0.fc10

* %check is not present; no test suite upstream.  I haven't a clue how to test 
   this.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no pkgconfig files.
* static libraries are present:
   no dynamic libraries, so static libs are OK in the -devel package.
   -static provide is present.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.