[Bug 448072] Review Request: spin-kickstarts - Kickstarts and templates for creating custom Fedora Spins

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: spin-kickstarts - Kickstarts and templates for creating custom Fedora Spins


https://bugzilla.redhat.com/show_bug.cgi?id=448072


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-06-06 12:10 EST -------
I thought I was going to say that this is the easiest package ever, but then it
failed to build:
  configure: error: no suitable Python interpreter found
I added a build dependency on python and it built fine.  I'm sort of confused as
to why python is needed or what actually gets built here.  It looks like you
could just copy the files from the tarball into place and dispense with
configure altogether, although I guess you could in the future do some kind of
processing.

rpmlint says:
  spin-kickstarts.src: W: strange-permission spin-kickstarts.spec 0600
No idea why this happens to some packages; I think the permissions get set
weirdly like that if you use rpmbuild -ta.  It's not worth fixing this as it's
not really a problem.  (It's not mode 666 or anything like that.)

  spin-kickstarts.noarch: W: no-documentation
As expected; not a problem.

You should probably terminate the sentence in %description with a period.

You should include the COPYING file as %doc.  (Which conveniently will eliminate
the rpmlint complaint.)

Checklist:
* source files match upstream:
   1c09ef032526f232246ccd83d1aae5645788ade5386b15ee512cdb3cf1a1271d  
   spin-kickstarts-0.01.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK (well, could use a period)
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
X license text upstream but not included in package.
* latest version is being packaged.
X BuildRequires missing python.
* %clean is present.
* package builds in mock (after fixing BuildRequires)
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  spin-kickstarts-0.01-1.fc10.noarch.rpm
   spin-kickstarts = 0.01-1.fc10
  =

* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.