[Bug 448458] Review Request: postal - mail server benchmark

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postal - mail server benchmark


https://bugzilla.redhat.com/show_bug.cgi?id=448458





------- Additional Comments From goyal.hemant at gmail.com  2008-06-06 13:40 EST -------
Hi Russell,

I am only performing a pre-review (not formal) of your packaging request. I am
not entitled to sponsor you, however someone else will in due time.

1] There seems to be a version inconsistency. The hyperlink for the source
version 0.70 leads to source version 0.69. Kindly check with upstream.

I have changed the version to 0.69 for further testing.

2] The RPM package fails to build due to a build error during compilation of the
program (please take a look at the log file attached)

Instead of

---------------------------------------
%configure --prefix=${RPM_BUILD_ROOT}
---------------------------------------
It is preferable to use

--------------------------------------
%configure --disable-static
--------------------------------------

3]Kindly avoid using hardcoded paths for %files section. Use macros as much as
possible. They are defined here : http://fedoraproject.org/wiki/Packaging/RPMMacros

Example:
/usr/sbin/rabid will become %{_sbindir}/rabid and so on

4] Kindly include the %dist tag with your release number as :
Release:        2%{?dist} for your future releases.

Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.