[Bug 444257] Review Request: nted - Musical score editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nted - Musical score editor


https://bugzilla.redhat.com/show_bug.cgi?id=444257





------- Additional Comments From rhbugs at n-dimensional.de  2008-06-09 02:40 EST -------
Watching the diffs, I find:
- Upstream COPYING is unchanged. Good.
- Upstream file licenses are unchanged. Good.
- You have made sure configure does not reset CXXFLAGS. Good catch.
- You are resetting icondir from $(datadir)/icons to $(datadir)/pixmaps for some
reason. Makes no difference to me.
- You have fixed a bunch more compiler warnings. Good. (Have you sent this
upstream?)
- More translations for nted.desktop. Good.
- po/nted.pot is now broken with CVS merge conflicts. Does not affect us.
- You have removed the "Requires: yelp". Hmm... whatever. "Help|Documentation"
will still need yelp, won't it?
- You also install the Italian manual. Good.

So there remains a single issue now that you are changing configure.in...
rebuilding the RPM from the SRPM appears to re-run aclocal, automake, autoconf,
autoheader, and we'd like to avoid this.

Looks like adding something like

sleep 1
find . -type f -name Makefile.in | xargs touch
touch aclocal.m4 config.h.in configure

at the end of %prep prevents automake&Co re-runs.

When this last one is done, I'll finally shut up and approve it.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.