[Bug 449928] Review Request: libwfut - WorldForge update tool library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libwfut - WorldForge update tool library


https://bugzilla.redhat.com/show_bug.cgi?id=449928





------- Additional Comments From atorkhov at gmail.com  2008-06-09 03:22 EST -------
Thanks, I'll check these issues.

(In reply to comment #3)
> It also appears that the system-tinyxml.patch is not working as expected.  To
> verify, try adding this to the end of %prep and rebuilding:
> 
> rm -f libwfut/tiny*
I'm patching this file libwfut/tinyxml.h to include system <tinyxml.h>. So, if
you remove it, you will get errors indeed. I'm doing so because this patch has
been merged upstream, so it has to mainain compatibility with systems where are
no system-wide tinyxml installed.
One thing that could be done - is patch removing tinyxml sources from tinyxml*
to ensure that we are not building against it.

> I think the problem is that you are patching configure.ac, but the changes are
> never propogated to the configure script itself.  To make the changes take
> effect, you will have to either patch the configure and Makefile.in files in
> addition to configure.ac (preferred), or run autoconf/automake in %prep to
> regenerate the files at build time.
Yes, I thought about this, but autotools is smart thing - in Makefile it is
checking if configure.ac or Makefile.in changes and then rebuild configure or
Makefiles. So in our case it's running configure twice - yes, this is
uneffective but working. Anyway, I'll make patch on configure and Makefile.in in
some future.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.