[Bug 442714] Review Request: sat-solver - Satisfyability Solver library which can be used to compute inter-package dependencies.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sat-solver - Satisfyability Solver library which can be used to compute inter-package dependencies.


https://bugzilla.redhat.com/show_bug.cgi?id=442714


lvillani at binaryhelix.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW
               Flag|needinfo?                   |




------- Additional Comments From lvillani at binaryhelix.net  2008-06-09 16:23 EST -------
Before uploading a new version of the package I need something to be explained:

Bad things:
- %{_includedir}/satsolver: As far as I know, %{_includedir}/satsolver/* gives
ownership to directory-contained files
- static libraries: as far as i know, upstream build system (based on cmake)
only produces static library archives and not shared objects and it seems that
other packages depending on this library statically link the library in their
final executable
- verbatim copy of the license: I included that in both packages using %doc
- rpmlint warning with sat-solver-devel: the inclusion of the verbatim copy of
the license should fix this
- $RPM_OPT_FLAGS: This is due to usage of cmake, afaik, using
-DCMAKE_BUILD_TYPE=FEDORA is sufficient, I added that to the cmake line

And now the questions:
I removed the *huge* testsuite (nearly 50MiB of stuff -compressed-) just to save
bandwidth (yes, I'm lazy), If needed I can keep the testsuite inside the tarball
but this will make the review process much slower because i'll have to upload
~100MiB of compressed tarballs (~50MiB of .src.rpm and ~50MiB of packaged snapshot).

Side notes:
As far as I know both sat-solver, libzypp and zypper can be retrieved only from
upstream' subversion (or by 'extracting' source tarball from SuSE' .src.rpm) so
the source archive is just a local subversion checkout with SCM directories
stripped out (ie: tar'ed using --exclude-vcs)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.