[Bug 435015] Review Request: libGPP4 - LGPL CCP4 library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libGPP4 - LGPL CCP4 library


https://bugzilla.redhat.com/show_bug.cgi?id=435015





------- Additional Comments From fenn at stanford.edu  2008-06-09 17:36 EST -------
(In reply to comment #7)
> I'm wondering if it wouldn't just be simpler to call the package libgpp4 and
> save yourself the trouble.  As it is, get things like this nice long
> %description which doesn't actually make it into any of the packages.
> 

I agree - I'll try to get this change made upstream, along with the others I've
gathered here.

> Plenty of rpmlint spew worth looking at:
> 
>   W: file-not-utf8 /usr/share/doc/libgpp4-devel-1.0.4/doc/latex/csym_f_page.tex
> doxygen creates this; I'm not sure if it's worth converting or if it even matters.
> 

Not sure what the best course of action is here - could just have doxygen spit
out the html docs...

> There are several complaints about the contents of the "test" directory being
> packaged as documentation, which I think is particularly ill-advised.  Why
> aren't the tests just called at build time in a %check section?
> 

For now I've removed the test directory from the -devel package, and I'll make
some suggestions upstream to move the test folder to TESTS in automake.

updated spec: http://www.stanford.edu/~fenn/packs/gpp4.spec
updated srpm: http://www.stanford.edu/~fenn/packs/gpp4-1.0.4-8.f8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.