[Bug 447948] Review Request: R-lmtest - Testing Linear Regression Models for R
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 12 01:38:10 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: R-lmtest - Testing Linear Regression Models for R
https://bugzilla.redhat.com/show_bug.cgi?id=447948
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |tibbs at math.uh.edu
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From tibbs at math.uh.edu 2008-06-11 21:38 EST -------
Builds fine; rpmlint notices that the license tag needs tweaking:
finds a bunch of utf8 complaints:
W: invalid-license GPL
I believe that, according to the COPYRIGHTS file, this is GPLv2 only.
rpmlint also complains about a bunch of non-utf8 files:
W: file-not-utf8 /usr/lib64/R/library/lmtest/man/lmtest.Rd.gz
W: file-not-utf8 /usr/lib64/R/library/lmtest/latex/bondyield.tex
and various other tex files. These all seem to come to one name, "Krämer", in
8859-1. I think it's worth converting these, since none of the produced
documentation files carry any encoding information.
rpmlint also has the two expected complaints about R-make-search-index.sh, which
can be ignored.
You should probably include the COPYRIGHTS file as %doc.
* source files match upstream:
884e9eb00874c4221e50be02e07db10e054241f1466b25017c3f9b296edbd636
lmtest_0.9-21.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field isn't valid.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
X rpmlint has valid complaints.
* final provides and requires are sane:
lmtest.so()(64bit)
R-lmtest = 0.9-1.fc10
=
/bin/sh
R
libR.so()(64bit)
libgfortran.so.3()(64bit)
* %check is present and all tests pass.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list