[Bug 450685] Review Request: R-DBI - Database Interface for R

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-DBI - Database Interface for R


https://bugzilla.redhat.com/show_bug.cgi?id=450685





------- Additional Comments From tibbs at math.uh.edu  2008-06-11 22:21 EST -------
Builds fine; rpmlint has the expected R complaints plus this:
  E: zero-length /usr/share/R/library/DBI/doc/DBI.R
Honestly I'm not sure what this is for or even where it comes from.  Perhaps an
R expert can tell us what's up, but I don't think this is a significant issue.

I would recommend using http://cran.r-project.org/web/packages/DBI/index.html
for the upstream URL; it's a bit better than an index page full of unrelated
directories and tarballs.

The description could use a little attention.  I'd recommend stealing something
like the following from upstream:
  A database interface (DBI) definition for communication between R and
  relational database management systems. 

* source files match upstream:
   91a5e5492e1731c122e43581db9d3c486b189b7d6aa79a9d0c5ccaa42b839751  
   DBI_0.2-4.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
? description could use a bit of fleshing out.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   R-DBI = 0.2-1.fc10
  =
   /bin/sh
   R

* %check is present and all tests pass
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is most of the package, but the package is small so there's no 
   point in splitting it.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.