[Bug 450410] Review Request: multiget - A multi-thread http/ftp file downloader

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: multiget - A multi-thread http/ftp file downloader


https://bugzilla.redhat.com/show_bug.cgi?id=450410





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-06-12 13:49 EST -------
Thanks. Then for 1.2.0-2:

Except for license issue:
* Source3
  - Please specify the URL of Source3 (or write as a comment
    how you received Source3)

* Buildroot
  - Please follow
    http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot

* BuildRequires
  - Currently gtk2-devel seems to pull automake, however
    for fixing broken install-sh symlink I think explicitly
    adding "BuildRequires: automake" is preferred.

* Perl module BRs:
  - For perl modules BuildRequires, please follow
    http://fedoraproject.org/wiki/Packaging/Perl#requiresandprovides
    (In short, "BuildRequires: perl-XML-Parser" must be
     "BuildRequires: perl(XML::Parser)" )

* Patch0 vs %optflags vs %configure
  - You seem to add %Patch0 to honor %optflags, however this Patch0
    is not needed.
    The reason your srpm does not honor %optflags is that %configure
    is called at %prep, not at %build. Actually %configure sets
    CPPFLAGS, however written at %prep, all those variables are
    reset.
    Move %configure to %build and then Patch0 is no longer needed.

* Macros
  - Use macros. /usr/share must be %{_datadir}.

* Timestamps
  - When using "cp" or "install" commands, add "-p" option to keep
    timestamps on installed files.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.