[Bug 451095] libcxgb3 hardware driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: libcxgb3 hardware driver


https://bugzilla.redhat.com/show_bug.cgi?id=451095





------- Additional Comments From dledford at redhat.com  2008-06-12 16:05 EST -------
(In reply to comment #1)
> Providing a specfile separately would make reviewer's life easier. Partial
> specfile review below.

specfile now available in the SRPM directory.

> > License: GPL/BSD
> 
> Invalid License tag. Should be:
> License: GPLv2 or BSD

Fixed

> > BuildRequires: libibverbs-devel >= 1.1, autoconf, libtool
> 
> libtool requires autoconf

Fixed

> > ExclusiveArch: i386 x86_64 ia64 ppc ppc64
> 
> Do you know for certain it doesn't work on sparc/sparc64?

No, but I also don't know that it *does* work on sparc/sparc64, and this isn't
your run of the mill user space package, it is a hardware driver in user space.
 Regardless though, I removed the ExclusiveArch.

> > Obsoletes: %{name}-devel
> 
> Why? There's no libcxgb3-devel in Fedora.

Because the upstream people distribute a package called libcxgb3-devel that's
really nothing but a .a static lib, and we put that in the -static file.  This
prevents conflicts when upgrading from the libcxgb3 included as part of the
OFED-1.3.tar.gz package by upstream to this package.

> > %install
> > rm -rf $RPM_BUILD_ROOT
> > %makeinstall
> 
> Don't use %makeinstall, use %{__make} install DESTDIR=$RPM_BUILD_ROOT instead
> (and make sure the Makefile supports DESTDIR for install target).

Fixed.

> > install -m 644 -D %{SOURCE1}
> ${RPM_BUILD_ROOT}%{_sysconfdir}/modprobe.d/libcxgb3.conf
> 
> Use install -p to preserve source timestamps.

Fixed.

I updated over the top of the previous package (aka, I built with the same
n-v-r, not a bumped one) so to get the new srpm you might have to force a
refresh if you are behind a proxy cache.  Otherwise, the specfile is now
available and includes the fixes listed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.