[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cylindrix - 3 degrees of freedom combat game


https://bugzilla.redhat.com/show_bug.cgi?id=448748





------- Additional Comments From j.w.r.degoede at hhs.nl  2008-06-15 17:44 EST -------
OKay, I now have it working on x86_64, and with these it should work on ppc too,
I've already submitted these patches upstream.

cylindrix-1.0-fix-packing.patch:
 Change #ifdef so that packing of applicable structures gets enabled,
 remove PACKED_STRUCT macro from struct members which have 1 byte alignment
 by default to shut up warnings. This fixes playback of the cylindrix logo fli
 on startup

cylindrix-1.0-arch-independ-file-read.patch:
 reading a memory dump of a struct from disk, will only work on the same
 machine as the struct was created, replace the simple fread(struct) calls
 with code which knows the data on disk is an intel struct dump and reads it
 in such a way it will work on any platform

cylindrix-1.0-use-int-not-long.patch:
 cylindrix uses longs all over the place in the sourcecode where it wants
 32 bits integers, however longs are 64 bit on 64 bit machines wrecking havoc,
 this patch replaces all use of long with int.


Note,

Even with these we are still not good to go, I need to also make the writing of
the overal stats system independent and currently saving any settings / stats
will not work at all when run as user, because you are starting cylindrix under
/usr/share/cylindrix where it cannot write its settings.

Instead from the script you should create a ~/.cylindrix, symlink the relevant
data dirs under there, and copy the config / pilot files, so that they can be
overridden and then start cylindrix-bin under ~/.cylindrix.

I'll be waiting for a new version from you to review with all the mentioned Must
FIX items fixed, these patches applied and the startup script modified so that
settings cna be saved.

Once that is done I'll start working on making the overal stat saving platform
agnostic.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.