[Bug 451587] Review Request: sound-theme-freedesktop - the default sound theme for the X sound theming spec

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sound-theme-freedesktop - the default sound theme for the X sound theming spec


https://bugzilla.redhat.com/show_bug.cgi?id=451587


mclasen at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From mclasen at redhat.com  2008-06-16 09:32 EST -------
Formal review:

rpmlint is silent

package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec file language: American English
spec file legibility: excellent
upstream sources: ok
buildable: yes
ExcludeArch: n/a
BuildRequires: ok
locale handling: ok
shared libs: ok
relocatable: n/a
directory ownership: ok, but I notice that /usr/share/sounds seems to be owned
by both alsa-utils and kde-filesystem. Might be worthwhile to move that to the
filesystem package, now that it is needed by yet another package. Can you
initiate that (ie file bugs) ?
duplicate filenames: ok
file permissions: ok
%clean: ok
macro use: consistent
content: permissible
large docs: n/a
%doc content: ok
headers: n/a
static libs: n/a
pc files: n/a
shared libs: n/a
devel package: n/a
libtool archives: n/a
gui apps: n/a
file ownership: ok
utf8 filenames: ok

Approved




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.