[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 16 18:08:41 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cylindrix - 3 degrees of freedom combat game


https://bugzilla.redhat.com/show_bug.cgi?id=448748





------- Additional Comments From j.w.r.degoede at hhs.nl  2008-06-16 14:08 EST -------
Much better, but still needs a tiny bit of work:

MUST FIX
--------

* Don't install cylindrix.rc, cylindrix.dsp and cylindrix.ico, those are visual
  studio project files
* When an icon is installed in the fdo icon hierarchy it should be named without
  extension in the .desktop file
* Apply one more patch to fix writing of overal stats on non i386 machines
  (I'll start working on this now, so don't expect it to be attached
   immediately).

SHOULD FIX
----------

* Change: 'make CFLAGS="$RPM_OPT_FLAGS"' to
  'make CFLAGS="$RPM_OPT_FLAGS -Wno-pointer-sign"'

  This way only the usefull warnings remain.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list