[Bug 445224] Review Request: stapitrace - user space instruction trace

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: stapitrace - user space instruction trace


https://bugzilla.redhat.com/show_bug.cgi?id=445224


jwboyer at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |jwboyer at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From jwboyer at gmail.com  2008-06-16 21:06 EST -------
source files match upstream:
 ab74f8ed90b8ba9a1d3904892622fc80 (tarball matches tarball found in upstream SRPM)
specfile is properly named, is cleanly written and uses macros consistently.
dist tag is present.
build root is correct
license field matches the actual license. (though itrace.c has GPL v2.1 listed,
which doesn't exist.  That should probably be fixed upstream)
license is open source-compatible.
license text not included upstream.
latest version is being packaged.
BuildRequires are proper.
compiler flags are appropriate.
%clean is present.
rpmlint is silent. 
owns the directories it creates.
doesn't own any directories it shouldn't.
no duplicates in %files.
file permissions are appropriate.
no scriptlets present.
code, not content.
documentation is small, so no -docs subpackage is necessary.
%docs are not necessary for the proper functioning of the package.
no headers.
no pkgconfig files.
no libtool .la droppings.

Needs fixing:

package meets naming and versioning guidelines.
package builds in mock:
http://koji.fedoraproject.org/koji/getfile?taskID=664952&name=build.log
package installs properly. (couldn't check)
debuginfo package looks complete. (couldn't check)
final provides and requires are sane (couldn't check)
if shared libraries are present, make sure ldconfig is run

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.