[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO


https://bugzilla.redhat.com/show_bug.cgi?id=432259





------- Additional Comments From goyal.hemant at gmail.com  2008-06-17 11:28 EST -------
> * Source file
> --------------------------------------------------------------
> 1038719 2008-02-16 15:54
> speech-dispatcher-0.6.6-7.fc7/speech-dispatcher-0.6.6.tar.gz
> 1039765 2008-06-08 00:04
> speech-dispatcher-0.6.6-9.fc7/speech-dispatcher-0.6.6.tar.gz
> --------------------------------------------------------------

Okay this is perhaps because the (cs).info file is destroyed.

> * Requires(preun) duplicates

Fixed now.

> * _sourcedir, %_builddir
> --------------------------------------------------------------
> install -p -m 0755 %SOURCE1 $RPM_BUILD_ROOT%{_initrddir}/
> --------------------------------------------------------------

Okay now it is fixed.

> --------------------------------------------------------------
> iconv -f ... -t .... speech-dispatcher-cs.info > speech-dispatcher-cs.info
> --------------------------------------------------------------
>     as you write now destroys this info file.

I have written to the speech-dispatcher community to find the correct encoding
of this file. I think I am not able to correctly determine the encoding of the
(cs) file which is resulting in the file's corruption.

> (In reply to comment #31)
> >   - To keep timestamps on installed files, please use
> > --------------------------------------------------------------
> > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
> > --------------------------------------------------------------

Fixed.

> * Macros in %changelog
> --------------------------------------------------------------
> - removed %%{_infodir}/dir file
> --------------------------------------------------------------
>      for example.

Okay i have fixed it for all macro occurrences in the changelog.

> > ==========================================
> > speech-dispatcherd dead but subsys locked
> > ==========================================
>    - Also "speech-dispatcher -d" seems to create 
>      %{_localstatedir}/run/speech-dispatcher.pid, however
>      "service speech-dispatcher stop" does not delete this file, which
>      needs fixing.

Hmm, right I have modified the init script and instructed speech-dispatcher to
create the pid file in /var/lock/subsys/$prog now. Start/stop/restart etc are
now functioning as expected.

i have named the prog speech-dispatcherd on purpose to distinguish between the
binary and daemon. (if thats what you mean by daemon is wrong?)
 
There was a problem with the logs being outputted on the console every time. So
I have modified speechd.conf (/etc/speech-dispatcher/speechd.conf) for two things:

1] Changed the log directory to /var/log/
2] Starting only espeak module by default.

(Please see the speechd.patch attached.)

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.