[Bug 401101] Review Request: sleuthkit - The Sleuth Kit (TSK)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sleuthkit - The Sleuth Kit (TSK)


https://bugzilla.redhat.com/show_bug.cgi?id=401101





------- Additional Comments From kwizart at gmail.com  2008-06-17 13:00 EST -------
Spec URL: 
http://kwizart.fedorapeople.org/SPECS/sleuthkit.spec
SRPM URL: http://kwizart.fedorapeople.org/SRPMS/sleuthkit-2.52-1.fc8.kwizart.src.rpm
Description: The Sleuth Kit (TSK)

This packages doesn't currently works and have showed some strange issues that
didn't appeared when <afflib/afflib.h> and <afflib/afflib_.h> was used (instead
of using the appropriate AFFLIB_CFLAGS).

Problem is:
/usr/include/afflib/afflib_i.h:343: error: redefinition of typedef 'AFFILE'
/usr/include/afflib/afflib.h:102: error: previous declaration of 'AFFILE' was here
*** [libtskimg_la-img_open.lo] Error 1

* This can be solved inside the afflib package by removing the AFFILE occurence
at l.383 of afflib_i.h
* On the other hand, this file is not meant to be used by the dependent
application, despite the dual header include (<afflib/afflib.h> and
<afflib/afflib_.h>) was submitted by the afflib developer to the sleutkit one.

* For some reasons, the linking properties of the libtsk.la are inherited by the
different binaries. I don't know how this can be avoided. This make the binaries
linked to unneeded library, and suggest that srch_strings (which is GPLv2+) is
linked against afflib (which is BSD with advertising), which is forbidden (even
if it probably don't use it directly).

Patch have been submitted to the different upsteam for advices.

@livinded
Your help would be welcome to maintain this package. I hope to have most of the
patches merged so the update will be easier. But a good reviewer is still missing.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.