[Bug 449962] Review Request: texlive-fonts-hebrew - Support using (Culmus) Hebrew fonts in TeXLive

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: texlive-fonts-hebrew -  Support using (Culmus) Hebrew fonts in TeXLive


https://bugzilla.redhat.com/show_bug.cgi?id=449962





------- Additional Comments From tibbs at math.uh.edu  2008-06-18 00:08 EST -------
Sorry for taking so long; I was distracted by another project.  At least I
remember why this seems so familiar; I reviewed tetex-fonts-hebrew a couple of
years ago.  We have a few new guidelines since then, and I might have missed a
couple of things, so there are a few issues even though this package is mostly
the same.

rpmlint is down to the file-not-utf8 and two dangling-relative-symlink
complaints.  I think these are all OK.

I know you're maintaining the tarball yourself; we have a guideline about that
now.  Please see http://fedoraproject.org/wiki/Packaging/SourceURL (the "We are
Upstream" section).

I'm not sure the License: is correct.  There is a GPL notice, but as far as I
can tell, nothing in the package specifies a version, so by the language in the
GPL notice any GPL version is acceptable (and hence the License: tag should
contain GPL+).  Also, the file "hebrew.ldf" seems to be under the LPPL.  If
that's correct then it seems to me that you should have:
  License: GPL+ and LPPL
with a comment before that indicating which parts are under which license.  But
I could be missing something.

The Summary isn't actually correct on F9 at least, because teTeX isn't in use there.

The /usr/share/texmf/fonts/enc/dvips/culmus directory seems to be unowned.

X source files can't be compared with upstream sources.
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
X summary shouldn't mention tetex.
* description is OK.
* dist tag is present.
* build root is OK.
X license field doesn't seem to match the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   tetex-fonts-hebrew = 0.1-9.fc10
   tex-fonts-hebrew = 0.1-9.fc10
  =
   /bin/sh
   /usr/bin/texhash
   /usr/bin/updmap-sys
   fonts-hebrew
   texlive

X fails to own /usr/share/texmf/fonts/enc/dvips/culmus
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.