[Bug 451542] Review-Request: perl-Algorithm-Permute - Handy and fast permutation with object oriented interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review-Request: perl-Algorithm-Permute - Handy and fast permutation with object oriented interface


https://bugzilla.redhat.com/show_bug.cgi?id=451542


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
            Summary|Review-Request: perl-       |Review-Request: perl-
                   |Algorithm-Permute - Handy   |Algorithm-Permute - Handy
                   |and fast permutation with   |and fast permutation with
                   |object oriented interface   |object oriented interface
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-06-18 06:00 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=667767
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
93c9e11af9511390379720fe046fb960  Algorithm-Permute-0.12.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test are ok with some tests got skipped
+ Package perl-Algorithm-Permute-0.12-1.fc10 =>
Provides: Permute.so perl(Algorithm::Permute) = 0.12
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
perl(:MODULE_COMPAT_5.10.0) perl(AutoLoader) perl(DynaLoader) perl(Exporter)
perl(strict) perl(vars) rtld(GNU_HASH)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.