[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO


https://bugzilla.redhat.com/show_bug.cgi?id=432259





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-06-18 13:48 EST -------
Created an attachment (id=309770)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=309770&action=view)
Slightly modified init script

For -11:

* Source tarball
(In reply to comment #39)
> > * Source file
> > --------------------------------------------------------------
> > 1038719 2008-02-16 15:54
> > speech-dispatcher-0.6.6-7.fc7/speech-dispatcher-0.6.6.tar.gz
> > 1039765 2008-06-08 00:04
> > speech-dispatcher-0.6.6-9.fc7/speech-dispatcher-0.6.6.tar.gz
> > --------------------------------------------------------------
> 
> Okay this is perhaps because the (cs).info file is destroyed.

  - It is not the point. The problem is that you are not using the source
    tarball written as %SOURCE0.
------------------------------------------------------------------
1038719 2008-02-13 19:31 speech-dispatcher-0.6.6.tar.gz
1039765 2008-06-08 00:04
speech-dispatcher-0.6.6-11.fc7/speech-dispatcher-0.6.6.tar.gz
------------------------------------------------------------------
    The former is what I downloaded from the URL written as %SOURCE0
    The latter is what you are using now, please don't.

  - Also, change the permissions of the file in srpm (i.e. %SOURCEx)
    to 0644.

* iconv
> > --------------------------------------------------------------
> > iconv -f ... -t .... speech-dispatcher-cs.info > speech-dispatcher-cs.info
> > --------------------------------------------------------------
> >	as you write now destroys this info file.
> 
> I have written to the speech-dispatcher community to find the correct
encoding
> of this file. I think I am not able to correctly determine the encoding of
the
> (cs) file which is resulting in the file's corruption.

  - The corruption is not due to the reason you wrote here.
    The reason is that iconv does not support redirection to its original
    file directory (which you modified in -11).

    So now iconv usage is okay, however build log says:
-------------------------------------------------------------------
   754		if /bin/sh
/builddir/build/BUILD/speech-dispatcher-0.6.6/missing --run makeinfo   -I . \
   755		 -o speech-dispatcher-cs.info speech-dispatcher-cs.texi; \
   756		then \
   757		  rc=0; \
   758		  cd .; \
   759		else \
   760		  rc=$?; \
   761		  cd . && \
   762		  $restore $backupdir/* `echo "./speech-dispatcher-cs.info" |
sed 's|[^/]*$||'`; \
   763		fi; \
   764		rm -rf $backupdir; exit $rc
   765	/builddir/build/BUILD/speech-dispatcher-0.6.6/missing: line 52:
makeinfo: command not found
   766	WARNING: `makeinfo' is missing on your system.	You should only need it
if
   767		 you modified a `.texi' or `.texinfo' file, or any other file
   768		 indirectly affecting the aspect of the manual.  The spurious
   769		 call might also be the consequence of using a buggy `make'
(AIX,
   770		 DU, IRIX).  You might want to install the `Texinfo' package or

   771		 the `GNU make' package.  Grab either from any GNU archive
site.
-------------------------------------------------------------------
    Now BuildRequires: makeinfo is missing.

* Macros expansion in %changelog
> > * Macros in %changelog
> > --------------------------------------------------------------
> > - removed %%{_infodir}/dir file
> > --------------------------------------------------------------
> >	 for example.
> 
> Okay i have fixed it for all macro occurrences in the changelog.

  - Actually more fixes are needed. Please use "rpmlint"
------------------------------------------------------------------
speech-dispatcher.src:279: W: macro-in-%changelog version
------------------------------------------------------------------

* Initscripts
  - Current initscript seems good, however as I guess showing the status
    to terminal is preferred, I modified your script a bit.

> i have named the prog speech-dispatcherd on purpose to distinguish between
the
> binary and daemon. (if thats what you mean by daemon is wrong?)
  - Sorry, for this part it seems I was just being confused.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.