[Bug 448867] Review Request: perl-parent - Establish an ISA relationship with base classes at compile time

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-parent - Establish an ISA relationship with base classes at compile time
Alias: perl-parent

https://bugzilla.redhat.com/show_bug.cgi?id=448867


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-06-18 16:11 EST -------
Really nothing to say here.

* source files match upstream:
   a04211e6fb2bf12913c63f904483550554013737ed8e1302fcbadca22ed3509e  
   parent-0.221.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(parent) = 0.221
   perl-parent = 0.221-1.fc10
  =
   perl(:MODULE_COMPAT_5.10.0)
   perl(strict)
   perl(vars)

* %check is present and all tests pass:
   All tests successful.
   Files=7, Tests=34,  0 wallclock secs ( 0.13 cusr +  0.03 csys =  0.16 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.