[Bug 450476] InfiniBand Connection Management library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: InfiniBand Connection Management library


https://bugzilla.redhat.com/show_bug.cgi?id=450476


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |ed at eh3.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From ed at eh3.com  2008-06-19 17:22 EST -------
Here is a quick review:

GOOD:
+ source matches upstream (SHA1SUM):
    bd18cd1c105275feb25461f659a3ad94e7c5db8c  libibcm-1.0.2.tar.gz
    bd18cd1c105275feb25461f659a3ad94e7c5db8c  libibcm-1.0.2.tar.gz.UP
+ license is correct and correctly included
+ builds in mock for F8 x86_64
+ rpmlint output is just some ignore-able warnings:
    libibcm.x86_64: E: zero-length /usr/share/doc/libibcm-1.0.2/ChangeLog
    libibcm-devel.x86_64: W: no-documentation
    libibcm-static.x86_64: W: no-documentation
+ naming OK
+ spec legible and macros look sane
+ shared libs (ldconfig) looks good
+ permissions OK
+ dir ownership OK
+ static libs are correctly in *-static


I don't see any blockers here so its APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.