[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO


https://bugzilla.redhat.com/show_bug.cgi?id=432259





------- Additional Comments From goyal.hemant at gmail.com  2008-06-20 05:23 EST -------
Hi,

SPEC File for revision 12 -
http://www.nsitonline.in/hemant/stuff/speechd-rpm/speech-dispatcher.spec

SRPM -
http://www.nsitonline.in/hemant/stuff/speechd-rpm/speech-dispatcher-0.6.6-12.fc7.src.rpm

(In reply to comment #43)
> Created an attachment (id=309770)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=309770&action=view) [edit]
> Slightly modified init script

Thanks for the modification :)

> For -11:
> 
> * Source tarball
> (In reply to comment #39)

> ------------------------------------------------------------------
> 1038719 20013 19:31 speech-dispatcher-0.6.6.tar.gz
> 1039765 2008-06-08 00:04
> speech-dispatcher-0.6.6-11.fc7/speech-dispatcher-0.6.6.tar.gz
> ------------------------------------------------------------------

OH okay, now I am using the correct tarball as available online.

>   - Also, change the permissions of the file in srpm (i.e. %SOURCEx)
>     to 0644.

I have changed the permissions of the following files to 0644:

1] speech-dispatcher-0.6.6.tar.gz
2] speech-dispatcher.spec
3] speechd.patch
4] speech-dispatcherd (with execute capability however)


>     Now BuildRequires: makeinfo is missing.

Okay had to add BuildRequire : texinfo for makeinfo

>   - Actually more fixes are needed. Please use "rpmlint"
> ------------------------------------------------------------------
> speech-dispatcher.src:279: W: macro-in-%changelog version
> ------------------------------------------------------------------

Yes :) I did not spot a few macros. (should ve run rpmlint before reporting back)

> * Initscripts
>   - Current initscript seems good, however as I guess showing the status
>     to terminal is preferred, I modified your script a bit.

Alright great! I have incorporated your changes.

Note : I build the SRPM on my box by commenting BuildRequires : ibmtts-devel
I am not sure how to obtain the RPM for this. (Although there is some mention of
an RPM for this here :
http://ibmtts-sdk.sourceforge.net/howto-make-gnome-speech-ibmtts-rpm.html)
I hope this does not have an undesirable effect?

(In reply to comment #44)

Yes, I am aware. I wrote two pre-reviews (#448458, #448292) and I will write
more detailed reviews now that I guess the speech-dispatcher package is in shape.

Furthermore, I have also created an FAS account "hemantg"and have requested
membership for cvsextras group.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.