[Bug 226302] Merge Review: pm-utils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: pm-utils


https://bugzilla.redhat.com/show_bug.cgi?id=226302





------- Additional Comments From kevin at tummy.com  2008-06-20 12:14 EST -------
Sorry for the long delay here. ;( 

rpmlint now says: 

pm-utils.src: W: mixed-use-of-spaces-and-tabs (spaces: line 39, tab: line 72)

Fix if you like.. not a big deal. 

pm-utils.src: W: strange-permission pm-utils-99hd-apm-restore 0755
pm-utils.src: W: strange-permission pm-utils-bugreport-info.sh 0755

ignore. 

pm-utils.x86_64: W: symlink-should-be-relative /usr/sbin/pm-hibernate
/usr/lib64/pm-utils/bin/pm-action
pm-utils.x86_64: W: symlink-should-be-relative /usr/sbin/pm-suspend-hybrid
/usr/lib64/pm-utils/bin/pm-action
pm-utils.x86_64: W: symlink-should-be-relative /usr/sbin/pm-suspend
/usr/lib64/pm-utils/bin/pm-action

Any luck fixing those?

pm-utils.x86_64: W: log-files-without-logrotate /var/log/pm-suspend.log

Shouldn't you add a Requires: logrotate and add a logrotate file for this?

pm-utils.x86_64: W: dangerous-command-in-%pre mv
pm-utils.x86_64: W: dangerous-command-in-%post mv

Not sure how to get around those, unless you don't need the mv commands anymore. 

pm-utils-devel.x86_64: W: no-documentation

ignore. 

On the requires, seems like kbd might need to be required for chvt?
pciutils was added for a pci.h header, but I don't think it's needed anymore. 
see bug: 182566

So, I would leave kbd, but remove pciutils... 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.