[Bug 448201] Review Request: pyvnc2swf - Vnc screen recorder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyvnc2swf - Vnc screen recorder


https://bugzilla.redhat.com/show_bug.cgi?id=448201





------- Additional Comments From michel.sylvan at gmail.com  2008-06-21 02:01 EST -------
The Bash trick should really be unnecessary: your package is noarch, so even on
64-bit systems the files will be in /usr/lib/pythonX.Y/... , never
/usr/lib64/pythonX.Y/... . The invocation you're using actually returns
/usr/lib64 on 64-bit systems, which is not where your files end up installed.

See
http://fedoraproject.org/wiki/Packaging/Python:

It might be a good idea to generate the wrapper script during the packaging
process, though:

Put this at the top of the specfile:

%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}

(note: not get_python_lib(1) which gives you the arch-specific directory)

%install
...
cat > $RPM_BUILD_ROOT%{_bindir}/vnc2swf-edit << EOF
exec python %{python_sitelib}/%{name}/edit.py "$@"
EOF

But do you really need to do this? edit.py works just fine if you symlink it.
Likewise with vnc2swf itself. I'd suggest just symlinking them all to /usr/bin.

Could not reproduce the ImportError you're getting -- movie comes from pyvnc2swf
so I'm not sure why you're getting that. Is that from *after* you install the
RPM or before?

Note that the recordwin script has, hardbaked into it, x11vnc and xwininfo.
x11vnc is part of libvncserver, but apparently it's not shipped in the Fedora
package at all. You might want to file a bug asking for it to be included, and
meanwhile, %exclude %{_bindir}/recordwin.sh from the %files section?

edit.py throws some exceptions if called without the right arguments; you might
want to fix the code path so that if any argument is missing, it exits after
displaying the error messages rather than attempting (futilely) to continue.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.