[Bug 449135] Review Request: gforge - GForge Collaborative Development Environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gforge - GForge Collaborative Development Environment


https://bugzilla.redhat.com/show_bug.cgi?id=449135





------- Additional Comments From musuruan at gmail.com  2008-06-21 10:15 EST -------
(In reply to comment #2)
> Event after rereading the packaging guidelines, I don't see the spec missing
> many of them, but maybe only some. Could you be more specific?

If you don't follow each guideline your package cannot be approved. Therefore
start correcting the one you noticed.

Then run rpmlint and correct the errors you'll get.

After that scrap all the ugly non-fedora bits like: 
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT

I suggest you to read other spec files that are in Fedora to improve your knowledge.

> Packaging old version is somewhat intentional, partly because that is the
> version I initially packaged at work, and partly to be able to test a proper
> package upgrade.

It is not a good choice to present a package review for an outdated version.
Just think about the security problem version 4.5 probably had and that have
been corrected in 4.5.19.

> About subpackages, I'm not sure about which ones might be useful, and I don't
> see the package mature enough for them.

You really should do subpackages. Thus the user can choose to install only the
subpackages he needs.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.