[Bug 450371] Review Request: pokegen - Strategy/RPG game engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pokegen - Strategy/RPG game engine


https://bugzilla.redhat.com/show_bug.cgi?id=450371





------- Additional Comments From supersonicandtails at gmail.com  2008-06-22 19:00 EST -------
__Review__

Here's the output from rpmlint:

[root at peter redhat]# rpmlint pokegen
pokegen.i386: W: no-documentation
pokegen.i386: W: incoherent-version-in-changelog 0.0.2-0.3
0.0.2-0.3.fc9.20080617svn210
pokegen.i386: W: undefined-non-weak-symbol /usr/lib/libpokebattle.so.0.0.2
_ZN10Pokebattle5Arena16remakeCollectionEv
pokegen.i386: W: undefined-non-weak-symbol /usr/lib/libpokebattle.so.0.0.2
_ZN10Pokebattle5Arena7cleanUpEv
pokegen.i386: W: undefined-non-weak-symbol /usr/lib/libpokebattle.so.0.0.2
_ZNK10Pokebattle4Team7pokemodEv
pokegen.i386: W: unused-direct-shlib-dependency /usr/lib/libpokebattle.so.0.0.2
/usr/lib/libQtXml.so.4
pokegen.i386: W: unused-direct-shlib-dependency /usr/lib/libpokebattle.so.0.0.2
/lib/libpthread.so.0
pokegen.i386: W: unused-direct-shlib-dependency /usr/lib/libpokebattle.so.0.0.2
/lib/libm.so.6
pokegen.i386: W: unused-direct-shlib-dependency /usr/lib/libpokemod.so.0.0.2
/lib/libpthread.so.0
pokegen.i386: W: unused-direct-shlib-dependency /usr/lib/libpokemod.so.0.0.2
/lib/libm.so.6

There was no output from "rpmlint pokegen-devel".

There are no doc files in the non-devel package, and there's an odd version jump
in the changelog that doesn't make sense to anyone reading:

* Sun Jun 17 2008 Ben Boeckel <MathStuf at gmail.com> 0.0.2-0.3
- New SVN revision
- Fixes for release versioning
- clean section fixed

* Sun Jun 08 2008 Ben Boeckel <MathStuf at gmail.com> 0.0.2-2
- New SVN revision
- Fixes for name change

There's also some unused libraries such as libpthread that I suppose are being
dragged in my qmake-qt4.  You can fix this by modifying the CONFIG variable in
your .pro file.

eg.
CONFIG -= qt \
thread \
X11 \
gui \
core

The SRPM fails to build in mock:
ERROR: No Spec file found in srpm: pokegen-0.0.2-0.3.fc9.20080617svn210.src.rpm

That's it. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.