[Bug 452458] Review Request: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords


https://bugzilla.redhat.com/show_bug.cgi?id=452458


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-06-23 00:39 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=675955

+ rpmlint is silent for SRPM But NOT for RPM.
perl-Crypt-GeneratePassword.noarch: W: file-not-utf8
/usr/share/doc/perl-Crypt-GeneratePassword-0.03/README
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).
==> You can use iconv to fix this.

+ source files match upstream url
65a9e924ba7496ebd13b70d863d8ae1b  Crypt-GeneratePassword-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok.
+ Package perl-Crypt-GeneratePassword-0.03-12.fc10 =>
Provides: perl(Crypt::GeneratePassword) = 0.03
Requires: perl(:MODULE_COMPAT_5.10.0) perl(Exporter) perl(strict) perl(vars)

SHOULD:
   * Use iconv to fix rpmlint warning before importing this package to CVS.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.