[Bug 452472] Review-Request: perl-TAP-Harness-Archive - Create an archive of TAP test results

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review-Request: perl-TAP-Harness-Archive - Create an archive of TAP test results


https://bugzilla.redhat.com/show_bug.cgi?id=452472


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
            Summary|Review-Request: perl-TAP-   |Review-Request: perl-TAP-
                   |Harness-Archive - Create an |Harness-Archive - Create an
                   |archive of TAP test results |archive of TAP test results
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-06-23 04:28 EST -------
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=676055
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5a92a2ae5b434692295555a68146703d  TAP-Harness-Archive-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok.
All tests successful.
Files=3, Tests=26,  1 wallclock secs ( 1.03 cusr +  0.09 csys =  1.12 CPU)
+ Package perl-TAP-Harness-Archive-0.03-1.fc10 =>
Provides: perl(TAP::Harness::Archive) = 0.03
Requires: perl(:MODULE_COMPAT_5.10.0) perl(Archive::Tar) perl(Cwd)
perl(File::Basename) perl(File::Find) perl(File::Path) perl(File::Spec)
perl(File::Temp)
 perl(TAP::Harness) >= 3.05 perl(TAP::Parser) perl(YAML::Tiny) perl(base)
perl(strict) perl(warnings)


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.