[Bug 450409] Review Request: rcssserver3d - Robocup Soccer Simulation Server 3D

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rcssserver3d - Robocup Soccer Simulation Server 3D


https://bugzilla.redhat.com/show_bug.cgi?id=450409





------- Additional Comments From hedayat at grad.com  2008-06-23 17:42 EST -------
OK, I thought that I should increase the release number after the approval of
the first rpm.

* Source files:
 - Yes, the package was a CVS version of the server. 0.6 has released yesterday
and I'll upload a new package using the released version. I don't know what URL
should I use for CVS versions of the package since there is no released tar.gz
for such versions.

- I've created %SOURCE1 using the pictures which can be found in the
user-manual.pdf. Should I specify this in the spec file? Where and how?

* BuildRequires:
No, I've written mesa-libGL-devel and mesa-libGLU-devel. OK, I'll use
libGL-devel and libGLU-devel.

* Requires:
* Requires for -devel subpackage:
OK

* Redundant description:
OK, I'll separate my Fedora spec file from the (to-become) generic spec file

* %vendor macro:
OK, the macro will be useless in the Fedora-only spec file anyway.

* Subpackages having different version from main package:
I've used a separate version since the -doc subpackage doesn't change that
often. BTW, I'll remove the version as desired.

* %prep vs %build:
* Timestamps
* Desktop file Category
OK

* ld.so.conf.d:
OK! The --disable-rpath option was added just because of Fedora!! Since the
guidelines say the rpath is prohibited I've added this option. It seems that
using rpath is allowed in this case, so I'll use it. The ld.so.conf file was
added for the same reason. I'll remove it too.
I'll remove tinyxml files from the package.

I'll upload a new spec/srpm based on your comments.
Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.