[Bug 452584] Review Request: mldonkey - Client for several P2P networks

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mldonkey - Client for several P2P networks


https://bugzilla.redhat.com/show_bug.cgi?id=452584





------- Additional Comments From rpm at greysector.net  2008-06-23 18:57 EST -------
Partial review:

http://bugzilla.livna.org/show_bug.cgi?id=1487#c43 is still not addressed fully:

Since it doesn't run as root, it's better to move the log to
/var/log/mldonkey/mldonkey.log
and set ownership of that directory accordingly.
---
http://bugzilla.livna.org/show_bug.cgi?id=1487#c39 is still not addressed fully:

mldonkey_df_monitor.sh:
email=`grep "^ mail =" /var/lib/mldonkey/downloads.ini | sed 's/ mail = //g'`

This is far from foolproof. It'll fail there are whitespace changes in that line.
---

I see that the install section has improved a bit (uses make install now), but
it's still far from ideal. Though I guess there's nothing wrong with it
packaging-wise.

BuildRequires:  dos2unix

Redundant BR, trivial to avoid using perl or tr. Not a blocker though.

It doesn't build on F-8, though:
error: Failed build dependencies:
        ocaml-lablgtk-devel >= 2.10.0 is needed by mldonkey-2.9.5-1.fc8

If I relax that BR to >= 2.6.0, it fails at compilation:
ocamlopt.opt -inline 10    -I src/utils/cdk  -I src/utils/lib  -I
src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I
src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I
src/config/unix  -I src/gtk2/gui  -I src/gtk2/gui/x11  -I src/gtk2/gui/win32  -I
icons/rsvg  -I +lablgtk2  -I src/networks/direct_connect  -I
src/networks/fasttrack  -I src/networks/fileTP  -I src/networks/bittorrent  -I
src/networks/donkey -c src/utils/net/ip_set.ml
/usr/bin/ocamlc.opt   -I src/utils/cdk  -I src/utils/lib  -I src/utils/ocamlrss
 -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I
src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/gtk2/gui 
-I src/gtk2/gui/x11  -I src/gtk2/gui/win32  -I icons/rsvg  -I +lablgtk2  -I
src/networks/direct_connect  -I src/networks/fasttrack  -I src/networks/fileTP 
-I src/networks/bittorrent  -I src/networks/donkey -c src/utils/net/ip_set.ml
/usr/bin/ocamlc.opt  -I src/utils/cdk  -I src/utils/lib  -I src/utils/ocamlrss 
-I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I
src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/gtk2/gui 
-I src/gtk2/gui/x11  -I src/gtk2/gui/win32  -I icons/rsvg  -I +lablgtk2  -I
src/networks/direct_connect  -I src/networks/fasttrack  -I src/networks/fileTP 
-I src/networks/bittorrent  -I src/networks/donkey -c src/utils/net/http_server.mli
ocamlopt.opt -inline 10    -I src/utils/cdk  -I src/utils/lib  -I
src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I
src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I
src/config/unix  -I src/gtk2/gui  -I src/gtk2/gui/x11  -I src/gtk2/gui/win32  -I
icons/rsvg  -I +lablgtk2  -I src/networks/direct_connect  -I
src/networks/fasttrack  -I src/networks/fileTP  -I src/networks/bittorrent  -I
src/networks/donkey -c src/utils/net/http_server.ml
ocamlopt.opt -inline 10    -I src/utils/cdk  -I src/utils/lib  -I
src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I
src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I
src/config/unix  -I src/gtk2/gui  -I src/gtk2/gui/x11  -I src/gtk2/gui/win32  -I
icons/rsvg  -I +lablgtk2  -I src/networks/direct_connect  -I
src/networks/fasttrack  -I src/networks/fileTP  -I src/networks/bittorrent  -I
src/networks/donkey -c src/daemon/common/commonOptions.ml
Fatal error: out of memory.
make: *** [src/daemon/common/commonOptions.cmx] Error 2
error: Bad exit status from /home/rathann/build/tmp/rpm-tmp.20151 (%build)

Note that I have 2GB RAM, which I think should be enough. Or is that a problem
with lablgtk?

Builds fine in mock/devel/i386.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.