[Bug 452251] Review Request: libmatthew-java - collection of java libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmatthew-java - collection of java libraries


https://bugzilla.redhat.com/show_bug.cgi?id=452251


fitzsim at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |fitzsim at redhat.com




------- Additional Comments From fitzsim at redhat.com  2008-06-24 11:41 EST -------
- MUST: rpmlint must be run on every package. The output should be posted...

$ rpmlint SRPMS/libmatthew-java-0.7.1-1.fc9.src.rpm
$ rpmlint RPMS/i386/libmatthew-java-0.7.1-1.fc9.i386.rpm
-soname /usr/lib/libcgi-java.so
-soname /usr/lib/libunix-java.so
$ rpmlint RPMS/i386/libmatthew-java-javadoc-0.7.1-1.fc9.i386.rpm
$ rpmlint RPMS/i386/libmatthew-java-debuginfo-0.7.1-1.fc9.i386.rpm

- MUST: The package must be named according to the Package Naming Guideli...

OK

- MUST: The spec file name must match the base package %{name}, in the fo...

OK

- MUST: The package must meet the Packaging Guidelines .

OK

- MUST: The package must be licensed with a Fedora approved license and m...

OK

- MUST: The License field in the package spec file must match the actual ...

OK

- MUST: If (and only if) the source package includes the text of the lice...

OK

- MUST: The spec file must be written in American English.

OK

- MUST: The spec file for the package MUST be legible. If the reviewer is...

OK

- MUST: The sources used to build the package must match the upstream sou...

I'm not sure what this comment means:

# debian version is newer than upstream

Source must come from the actual upstream, not from another
distribution.  If Debian's version is better than upstream then add
another patch with those changes.

- MUST: The package must successfully compile and build into binary rpms ...

OK

- MUST: If the package does not successfully compile, build or work on an...

OK

- MUST: All build dependencies must be listed in BuildRequires, except fo...

OK

- MUST: The spec file MUST handle locales properly. This is done by using...

OK

- MUST: Every binary RPM package which stores shared library files (not j...

The JNI objects should go in %{_libdir}/%{name}, not %{_libdir}.  See:

http://fedoraproject.org/wiki/Packaging/Java#Packaging_JAR_files_that_use_JNI

- MUST: If the package is designed to be relocatable, the packager must s...

OK

- MUST: A package must own all directories that it creates. If it does no...

OK

- MUST: A package must not contain any duplicate files in the %files list...

OK

- MUST: Permissions on files must be set properly. Executables should be ...

OK

- MUST: Each package must have a %clean section, which contains rm -rf %{...

OK

- MUST: Each package must consistently use macros, as described in the [w...

OK

- MUST: The package must contain code, or permissable content. This is de...

OK

- MUST: Large documentation files should go in a -doc subpackage. (The de...

OK

- MUST: If a package includes something as %doc, it must not affect the r...

OK

- MUST: Header files must be in a -devel package.

OK

- MUST: Static libraries must be in a -static package.

OK

- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfi...

OK

- MUST: If a package contains library files with a suffix (e.g. libfoo.so...

See JNI comment above.

- MUST: In the vast majority of cases, devel packages must require the ba...

OK

- MUST: Packages must NOT contain any .la libtool archives, these should ...

OK

- MUST: Packages containing GUI applications must include a %{name}.deskt...

OK

- MUST: Packages must not own files or directories already owned by other...

OK

- MUST: At the beginning of %install, each package MUST run rm -rf %{buil...

OK

- MUST: All filenames in rpm packages must be valid UTF-8.

OK

- SHOULD: If the source package does not include license text(s) as a sep...

OK

- SHOULD: The description and summary sections in the package spec file s...

s/java/Java/ in the summary tag.

Usually description is in paragraph form, not bullet points.  I'll
leave this up to you though.

- SHOULD: The reviewer should test that the package builds in mock. See [...

A Rawhide i386 mock build fails:

+ /usr/lib/rpm/find-debuginfo.sh --strict-build-id
/builddir/build/BUILD/libmatthew-java-0.7.1
extracting debug info from
/var/tmp/libmatthew-java-0.7.1-1.fc10-root-mockbuild/usr/lib/libcgi-java.so
*** ERROR: No build ID note found in
/var/tmp/libmatthew-java-0.7.1-1.fc10-root-mockbuild/usr/lib/libcgi-java.so
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.14107 (%install)
    Bad exit status from /var/tmp/rpm-tmp.14107 (%install)
Child returncode was: 1

- SHOULD: The package should compile and build into binary rpms on all su...

rpmbuild works on i386.

- SHOULD: The reviewer should test that the package functions as describe...

No demos to try.

- SHOULD: If scriptlets are used, those scriptlets must be sane. This is ...

The if ... fi formatting is a little strange, but OK.

- SHOULD: Usually, subpackages other than devel should require the base p...

Does the javadoc subpackage actually need the base package to be
installed?  Usually javadoc subpackages are an exception to this
guideline.

- SHOULD: The placement of pkgconfig(.pc) files depends on their usecase,...

OK

- SHOULD: If the package has file dependencies outside of /etc, /bin, /sb...

OK


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.