[Bug 443771] Review Request: lmms - Linux MultiMedia Studio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lmms - Linux MultiMedia Studio


https://bugzilla.redhat.com/show_bug.cgi?id=443771





------- Additional Comments From thomas.moschny at gmx.de  2008-06-25 04:07 EST -------
(In reply to comment #3)
> Need to have (STK) packaged also.

Started, but not finished yet.
 
> So, few others notes.
> * Qt i18n 
> configure:21663: checking Qt translations
> configure:21679: WARNING: *** not found! You may want to install a Qt i18n package

Fixed, and will be fixed in 0.3.3.

> * Source0
> http://downloads.sourceforge.net/lmms/lmms-%{version}.tar.bz2
> instead of 
> http://prdownloads.sourceforge.net/lmms/lmms-0.3.2.tar.bz2

Fixed.

> * You can use:
> %configure --disable-static \
> %ifnarch i386
> --without-vst \
> %endif
> <space>

Done.

> * You need to use make %{?_smp_mflags} (unless it fails and you need to drop a
> comment if it does.

Parallel building indeed fails for 0.3.2, but upstream told me it works for
their current trunk. We'll see. Disabled for now.

> * Prevent timestramps changes at install :
>  make DESTDIR=%{buildroot} install INSTALL="install -p"

Pretty uncommon and not covered by the package guidelines.

> * CFLAGS : -ftree-vectorize -ftree-loop-linear are used and may override some of
> our CFLAGS (or not - anyway we may need to see if this is really needed).

-ftree-vectorize
     Perform loop vectorization on trees. This flag is enabled by
     default at `-O3'.

-ftree-loop-linear
     Perform linear loop transformations on tree.  This flag can
     improve cache performance and allow further loop optimizations to
     take place.

Don't see a reason to not enable this.

> * post/postun
> update-mime-database %{_datadir}/mime &> /dev/null || :
> update-desktop-database &> /dev/null || :
>  You need to add full path for them like /usr/bin/update-desktop-database
> and remove the &> /dev/null (as if it fails, we will not know)
> only the last || : would be needed

Copied that from
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database.

> * desktop file 
> - Usually GNOME HIG compliance requires to use verbs in Comments

Will ask upstream to fix that.

> - Icon and Exec should mention the path (and .png)

Can you explain what you mean?

> It would be fine to drop a symlink into /usr/share/pixmaps 

Done.

> - X-Desktop-File-Install-Version=0.3 is written before desktop-file-install is
used.
> - Categories / "MimeType" is a list and does not have a semicolon as trailing
> character, fixing - this could be fixed at source also.

Again, will ask upstream to fix that. Meanwhile, not a real problem, because
that's fixed by desktop-file-install.

> - License is GPLv2+ - OK

Found one file (drumsynth) that has a MIT license in it.

Spec URL: http://thm.fedorapeople.org/lmms.spec
SRPM URL: http://thm.fedorapeople.org/lmms-0.3.2-2.fc9.src.rpm

%changelog
* Wed Jun 25 2008 Thomas Moschny <...> - 0.3.2-2
- Update license tag.
- Add patch to fix plugin dir on 64bit archs.
- Add ladspa-caps-plugins dependency.
- Suggestions from the review:
  * Simplify configure step.
  * Fix sf.net download link.
  * Add patch to let configure find the qt translations.
  * Link icon to _datadir/pixmaps.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.