[Bug 452251] Review Request: libmatthew-java - collection of java libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmatthew-java - collection of java libraries


https://bugzilla.redhat.com/show_bug.cgi?id=452251


fitzsim at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+, fedora-cvs?




------- Additional Comments From fitzsim at redhat.com  2008-06-25 11:06 EST -------
Just one more change request.  It may produce the same result, but the more
conventional way to link a shared object is to pass -shared to gcc.  So I'd
recommend replacing:

-Wl,-soname=$@

in soname.patch with

-shared

You should work with upstream to clean up these build scripts.  Most importantly
they should not be invoking the linker directly, but there's also the make
variables: specifying CFLAGS on the make line should add to, not override, the
tools options.  So if upstream is fixed you should only need:

make %{?_smp_mflags} \
    CFLAGS='%{optflags}'\
    GCJFLAGS='%{optflags}' \
    LDFLAGS='%{optflags}' \
    PPFLAGS='%{optflags}'

Please make the -shared change when you commit the package.

Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.