[Bug 452559] Review Request: zfuzz - Z fuzz - Type-checker and LaTeX style for Z spec language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: zfuzz - Z fuzz - Type-checker and LaTeX style for Z spec language


https://bugzilla.redhat.com/show_bug.cgi?id=452559





------- Additional Comments From pertusus at free.fr  2008-06-25 16:10 EST -------
Some remarks on the spec file:

* I think it is better to use sed instead of perl for one-liners

* gcc is not needed in BuildRequires (see the exceptions in guidelines)

* use the virtual provides like tex(tex) and tex(latex) instead of 
  explicitely depending on texlive

* coments are good, but some of your comments are, in my opinion, (much) 
  too long. For example the one about not splitting the package could be

# the package contains few glyphs, but separating a font subpackages would
# seemed unnecessary and confusing since it should be the only package using 
# the fonts

* also some comments are redundant. For example you comment twice that 
  mf and pk files are installed such that they don't have to be recreated.

* paraphrasing the whole INSTALL file is not useful either.

* you could split out the latex part, in tex-zfuzz.

* the %description is much too long.

* regarding the .pdf it is better to have the source and be able to
  rebuild from source in fedora. But even if it cannot be regenerated
  it is better to package it.
  There is no license issue because it is BSD, and it can be allowed in 
  fedora because it is content.

* The %build section has too much comments. Most of your code is 
  self-documented

* I think that a patch for adding the DESTDIR would be better than the
  substitution and I hope that upstream would accept it.

* I don't think that CFLAGS can be defined when make is launched.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.