[Bug 446158] Review Request: xesam-glib - A GObject library for dealing with Xesam services

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xesam-glib - A GObject library for dealing with Xesam services


https://bugzilla.redhat.com/show_bug.cgi?id=446158





------- Additional Comments From dakingun at gmail.com  2008-06-25 17:55 EST -------
(In reply to comment #1)
> I have absolutely no idea what Xesam is; could you at least define it in your
> %description?
> 
> I would suggest using http://xesam.org/people/kamstrup/xesam-glib/ as your URL:
> tag; this at least has some information on the package.
> 
> rpmlint is quiet except for the following:
>   xesam-glib.x86_64: W: unused-direct-shlib-dependency
>    /usr/lib64/libxesam-glib.so.0.0.0 /lib64/libdbus-1.so.3
> This means that the libxesam-glib links against libdbus-1 but doesn't actually
> call any functions from it.  There's a quick libtool tweak that should fix this:
>
http://fedoraproject.org/wiki/PackageMaintainers/CommonRpmlintIssues#unused-direct-shlib-dependency
>  
> I note that 0.3 is out now; I don't see anything that would change this review.
>

I've addressed all the issues you pointed out above.
 
> I also noticed that there's a test suite in the source.  A naive "make check"
> didn't work for me, though.  Have you looked into whether or not it's runnable?
>
One would need a desktop search service that support xesam specifications for
'make check' to work. Only the current versions of strigi and beagle have such
support (to my knowledge); tracker support is coming along.

Thanks for the review.

Spec URL: ftp://czar.eas.yorku.ca/pub/xesam/xesam-glib.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/xesam/xesam-glib-0.3.0-1.fc9.src.rpm
 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.