[Bug 450466] Review Request: clive - Video extraction tool for user-uploaded video hosts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clive - Video extraction tool for user-uploaded video hosts


https://bugzilla.redhat.com/show_bug.cgi?id=450466





------- Additional Comments From mnowak at redhat.com  2008-06-26 15:56 EST -------
I still guess it's good idea to be consistent in using macro- v. variable- style

   rm -rf $RPM_BUILD_ROOT

but

   %{__sed}

"""
You should pick a style and use it consistently throughout your packaging.

Mixing the two styles, while valid, is bad from a QA and usability point of
view, and should not be done in Fedora packages. 
"""

see
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.