[Bug 453016] Review Request: un-fonts-core - Korean TrueType fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: un-fonts-core - Korean TrueType fonts


https://bugzilla.redhat.com/show_bug.cgi?id=453016





------- Additional Comments From petersen at redhat.com  2008-06-27 03:46 EST -------
rpmlint says:

 un-fonts-core.noarch: W: incoherent-version-in-changelog 1.0.2-080608-1 1.0-1.fc9

How about using the latest released 1.0.2-080608 tarball?
(Also since you note it in the changelog.:)

I think the version can be just 1.0.2 and then the datestamp can go into the release
field following http://fedoraproject.org/wiki/Packaging/NamingGuidelines.

Probably 
 %define fontdir     %{_datadir}/fonts/%{name}
 %define archivename   un-fonts

 Name:           un-fonts-core

would be ok for this package.

 un-fonts-core.src: W: invalid-license GPL v2

The license url http://korea.gnu.org/copyleft/gpl.ko.html embedded in the ttf fonts
is broken.  Could you please contact upstream to clarify their intention on the GPL
version.  It would be better if the fonts files just stated the GPL version
(eg "version 2 or later") than referring to a url which might change or disappear.
Anyway currently the License tag should be GPLv2+ or maybe GPLv2.

(There seems to be a translation at
http://korea.gnu.org/documents/copyleft/gpl.ko.html
but again Fedora, like the FSF, would not recognise the unofficial translation.
 So it
does not really help.)

You don't use xorg-x11-font-utils or ttmkfdir so those buildrequires can be dropped.

It would be good to have a bit more information in the description.
There can also be summary and description in Korean added.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.