[Bug 450482] libibumad package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: libibumad package


https://bugzilla.redhat.com/show_bug.cgi?id=450482


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |ed at eh3.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From ed at eh3.com  2008-06-28 13:51 EST -------
Here's a review:

GOOD:
+ source matches upstream SHA1SUM:
    f50dcb3f1bc789dd2b951aae176b58774c6aeb44  libibumad-1.2.0.tar.gz
    f50dcb3f1bc789dd2b951aae176b58774c6aeb44  libibumad-1.2.0.tar.gz.UP
+ license ("GPLv2 or BSD") is correct and correctly included
+ proper use of ldconfig
+ *.la is correctly removed
+ builds locally (F8 x86_64)  w/ the libibcommon-devel installed
+ rpmlint reports two ignore-able warnings:
    libibumad-devel.x86_64: W: no-documentation
    libibumad-static.x86_64: W: no-documentation
+ dir ownership looks good
+ permissions look good

NEEDSWORK:
- The %install sections is missing a:
    rm -rf %{buildroot}
  at the beginning
- Please remove the ExclusiveArch:


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.