[Bug 450483] libibmad package
bugzilla at redhat.com
bugzilla at redhat.com
Sat Jun 28 18:06:42 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: libibmad package
https://bugzilla.redhat.com/show_bug.cgi?id=450483
------- Additional Comments From ed at eh3.com 2008-06-28 14:06 EST -------
Perhaps I can paste the correct review notes into the little Firefox text
box this time. Let's watch and see how it goes...
GOOD:
+ source matched upstream SHA1SUM:
743b35ca9257cf8f5f3d022df6161acc31301994 libibmad-1.2.0.tar.gz
743b35ca9257cf8f5f3d022df6161acc31301994 libibmad-1.2.0.tar.gz.UP
+ license is correct and correctly included
+ builds locally on F8 x86_64 w/ libibumad-devel installed
+ proper use of ldconfig
+ the *.la are deleted
+ permissions and dir ownership look good
+ rpmlint reports these two ignore-able warnings:
libibmad-devel.x86_64: W: no-documentation
libibmad-static.x86_64: W: no-documentation
NEEDSWORK:
- please remove the ExclusiveArch:
- please add "rm -rf %{buildroot}" or equivalent to the
beginning of %install
Yup, I think that was the one. [*shakes head slowly and walks away*]
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list