[Bug 448717] Review Request: gnome-rdp - rdesktop front end

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-rdp - rdesktop front end


https://bugzilla.redhat.com/show_bug.cgi?id=448717


guido.ledermann at googlemail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guido.ledermann at googlemail.c
                   |                            |om




------- Additional Comments From guido.ledermann at googlemail.com  2008-06-29 03:51 EST -------
I'm doing a pre-review to become sponsored and these are my comments on your
package. 

* rpmlint gives errors and warnings. See
http://fedoraproject.org/wiki/Packaging/Guidelines#Use_rpmlint
* %defattr is placed a bit too late, should be before %files
* your program uses localized files. You must not use %{_datadir}/locale/ to
place them sonewhere. You should use findlang. See
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
* BuildRequires: are you sure there are no redundant requirements? (glib2-devel
gtk2-devel gtk-sharp2-devel gnome-sharp-devel)
* if your package contains a GUI application, please follow
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
* Group: I'd use Application/Internet rater than Applications/System. All
vnc/rdesktop/tsclient applications are there.
* Patch0: why do you call it gnome-rdp-fedora.patch? It is not fedora specific,
so you should call it different (distribution neutral).
* License: please include the license file as documentation. See
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

That's all for now. Again: this is just my pre-review, not an official review. 




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.